search

ThoughtGang / opdis

libopcodes-based disassembler
GNU General Public License v2.0
35 stars 10 forks source link

minor bug fixes. #1

Closed grugq closed 12 years ago

grugq commented 12 years ago

I've fixed a couple compile time issues with clang. I'm not totally clear on the changes i've made in the opdis/ directory as there were some issues with missing return values. I've guessed '0' is for fail states, but better check that I got them correct.

mkfs commented 12 years ago

Looks reasonable. Guess I kinda got used to the implicit return-NULL in all them dynamic languages.

And gcc let me get away with it! Wtf. I need to switch to the Intel compiler.

On Sun, Jul 22, 2012 at 2:25 AM, thaddeus t. grugq < reply@reply.github.com

wrote:

git pull https://github.com/grugq/opdis master

rofl0r commented 12 years ago

-Wall -Wextra would help as well...

mkfs commented 12 years ago

But then shit won't build!! ;)

Yeah, I was too lazy to make autotools generate proper Makefiles. Hafta fix that.

rofl0r commented 12 years ago

not -Werror, -Wextra

but dont make it default, since -Wextra is not supported by gcc < 4