search

ThoughtWorksInc / Binding.scala

Reactive data-binding for Scala
https://javadoc.io/page/com.thoughtworks.binding/binding_2.13/latest/com/thoughtworks/binding/index.html
MIT License
1.59k stars 108 forks source link

Optional attribute support #103

Closed glmars closed 6 years ago

glmars commented 6 years ago

Should fix https://github.com/ThoughtWorksInc/Binding.scala/issues/90

@Atry please, review and do not merge (I have some additional idea about naming)

Atry commented 6 years ago

Looks good to me!

glmars commented 6 years ago

My idea was introducing special "namespace" for Binding.scala specific "prefixes" like data:, option: (and bind:id from: https://github.com/ThoughtWorksInc/Binding.scala/issues/104) to prevent possible conflicts with fields in custom tags. So all of this should start with bind:: bind:data:someattr, bind:option:someattr and bind:id.

But now I understand what it isn't necessary. Please forget about this and merge this PR whenever you want.

Atry commented 6 years ago

Thank you! @glmars

merged.