search

ThoughtWorksStudios / eb_deployer

AWS Elastic Beanstalk blue-green deployment automation from ThoughtWorks Mingle Team
MIT License
400 stars 94 forks source link

Accept yellow health flag #67

Closed dziemid closed 8 years ago

dziemid commented 8 years ago

Pull request for https://github.com/ThoughtWorksStudios/eb_deployer/issues/66

We introduced optional 'accepted_healthy_states' config option, that let's you specify a list of valid states, for example:

accepted_healthy_states:
    - Green
    - Yellow

Happy to hear any feedback and improve it as needed. Otherwise we tested it and it works for our use-case. Default behaviour didn't change.

wpc commented 8 years ago

@dziemid Very good work! I have made some comments inline for place need small changes. Looking forward your update.

-- wpc

wpc commented 8 years ago

And don't worry about the travis failure. It caused by using very old version of bundler. I have already fixed it in master.

dziemid commented 8 years ago

@wpc thank you for reviewing. I've added extra step in the test and a little bit of documentation for :accepted_healthy_states.

Please let me know if there is anything else.