ThoughtfulDev / EagleEye

Stalk your Friends. Find their Instagram, FB and Twitter Profiles using Image Recognition and Reverse Image Search.

Do What The F*ck You Want To Public License

4.18k stars 559 forks source link

Fix dependency conflict for issue #72

Closed NeolithEra closed 5 years ago

NeolithEra commented 5 years ago

71

NeolithEra commented 5 years ago

@ThoughtfulDev Could you please help me review this issue?
Thank you very much!

BTW, dependency conflict problems are very common in practice in python ecosystem. I have encountered the issues several times. What's your oppinion on the challenges of detecting and repairing such issues? And how to avoid dependency conflict problems among python projects, especially from the ecosystem's perspective?

ThoughtfulDev commented 5 years ago

Done. Indeed there could be some sort of dependency checker which for example checks your requirements.txt file to avoid such issues like you said e.g urllib being already bundled in request so no need to put it separately.

Or there could be some sort of warning when running pip install -r ... for example:

urllib3 is already required by package XY but is listed separately in the specified file. Do you still want to continue (y/N)?

Anyway. Thanks for the contribution :)