Thousandaire / thousandaire

Hellow python! Hellow rich world!
MIT License
1 stars 3 forks source link

Unit test for data classes. #11

Closed ioumu8 closed 3 years ago

ioumu8 commented 4 years ago

Unit test for Data.

b821213 commented 4 years ago

I am not sure if this will be our first submitted PR of unit test, but anyway can you create the workflow file in this PR as well?

b821213 commented 4 years ago

Besides, while unit tests for dataset.py are highly co-relevant, I suggest to split it into more PRs, for example one for Data, one for DataController, one for Dataset... It's better to make sure all existing unit tests are already good before we implement more unit tests.