search

Threagile / threagile

Agile Threat Modeling Toolkit
https://threagile.io
MIT License
577 stars 126 forks source link

fix: required fields on wrong level in schema #30

Closed resident-uhlig closed 8 months ago

resident-uhlig commented 2 years ago

Hello,

when using the provided schema.json then my IDE (IntelliJ IDEA) doesn't show some required fields as missing but the threagile CLI does when creating the report. The IDE also shows that the schema.json itself is invalid.

This commit should fix this. Basically it just moves the required property up one level.

Best regards.

resident-uhlig commented 2 years ago

question: Basically the issue was a missing } ?

Well, it wasn't missing but rather at the wrong position.

sfrycertinia commented 1 year ago

While the schema is being updated could the meta schema be set to a valid one? I suspect http://json-schema.org/draft-07/schema#?

sfrycertinia commented 1 year ago

I think id should also be $id?

fluential commented 11 months ago

Any update on this? Can we get this merged?