search

Threagile / threagile

Agile Threat Modeling Toolkit
https://threagile.io
MIT License
577 stars 126 forks source link

Do Asset ID's *need* to be sanatized? #82

Open akinnane opened 3 weeks ago

akinnane commented 3 weeks ago

This function rejects asset IDs that conform to our own resource naming conventions. Is there a good reason why this check exists, and why I shouldn't disable this code for our assets?

https://github.com/Threagile/threagile/blob/49f47fb164123edd14400c25404fd5bc6c951f37/pkg/model/parse.go#L755-L761

ezavgorodniy commented 2 weeks ago

I don't know the original idea @cschneider4711 had when this code was added but I'd say "id is id" and currently tool is providing a way to add non sanitized and more human friendly into name and description, while id is used in many places for references purpose.