ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.38k stars 1.64k forks source link

Unsorted 'using' statements vs merge conflicts #1681

Closed raman-m closed 1 year ago

raman-m commented 1 year ago

Expected Behavior

All using statements are:

Merge conflicts should go away in PRs. At least rebasing feature branches will be easier.

Actual Behavior / Motivation

There are multiple merge conflicts in old PRs which block code review and PR management.

Steps to Reproduce the Problem

SA1135 violation was since the StyleCop adding to the solution by df86052a31235d4dd740020dc8ddf574b3b1b81a, the rule violation was not fixed till #1663 because most of C# files had using block inside of namespace declarations. The situation with conflicts became worst after merging #1663 where StyleCop violations of SA1135 rule (of Readability Rules) were fixed.

Specifications