search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.38k stars 1.64k forks source link

#1681 'using' statements life hacks #1682

Closed raman-m closed 1 year ago

raman-m commented 1 year ago

Fixes #1681

Proposed Changes

raman-m commented 1 year ago

@TomPallister Hey Tom! Could you merge it ASAP please? 🆘 It prevents me from smooth repo support, and it's hard to do quick code reviews now! 🙏 🆘 These merge conflicts are blockers of code review process! I hope after merging this PR the situation will be better, and we will be able to increase the speed of PR closing. 😥

raman-m commented 1 year ago

@RaynaldM Hi Ray! Could you spare a minute please to approve this PR? The PR doesn't contain real logic. These are workarounds with usings. The goal is minimizing the number of using statements in files to have less probability of merge conflicts in usings block.

raman-m commented 1 year ago

@RaynaldM discussed on Aug 1

You have answered for me "But I'm not sure, because every junior C# developer knows that global usings are located in some files." "make short comment line // See global usings in ../Usings.cs" is a good idea.

I've decided not adding this comment line because implicit usings are disabled now and all global usings are presented in this file. So, this idea looks like overhead one as for me!

In conclusion, I think you can keep ImplicitUsing at true, and just put the little comment "think about looking into GlobalUsing."

Implicit usings are disabled at all. We will use global explicit usings. This is more clear approach to manage usings.

Pay attention that sample projects have implicit usings disabled also, but they won't have Usings.cs file because of small code base. So, there is no sense to add global usings to the sample projects, therefore all using statements will be explicit for samples.

Could you review once again and approve please?

raman-m commented 1 year ago

@TomPallister I will appreciate your merging soon!

raman-m commented 1 year ago

@RaynaldM approved these changes on Sep 20

Thanks for approval! But your approvals are now gray in all PRs! 😱 👇 image

And here is Reviewers block 👇 image

I cannot get it! It seems you are no longer a member of Ocelot team! @RaynaldM Have you left Ocelot Core team? Or did someone remove you from the team?

RaynaldM commented 1 year ago

@raman-m, no, I received a message last week telling me that I was no longer part of the team

raman-m commented 1 year ago

@RaynaldM commented on Sep 20 no, I received a message last week telling me that I was no longer part of the team

Oh, my gosh! I am very sorry! It seems you were removed from the team by Tom. I am shocked. All your approvals are gray for all PRs 😨 I will figure out why he did that.

Don't worry, I can still add you to the team. Maybe Tom tried to change security policies...

P.S. Please, forward GitHub message aka notification concerning your removal from the team, to me: dotnet044 at gmail dot com

RaynaldM commented 1 year ago

P.S. Please, forward GitHub message aka notification concerning your removal from the team, to me: dotnet044 at gmail dot com

done

raman-m commented 1 year ago

@RaynaldM Welcome to the team!... once again! 😉

raman-m commented 1 year ago

@RaynaldM Approve once again please!