Follow-up #1377: `WebSocketsProxyMiddleware` concerns

[raman-m]

Relates to #1377 #1689

Bug fixes:

• 1377

• 1689

Initial issue in #1377:

Code review comment on Sep 28

Expected Behavior / New Feature

The WebSocketsProxyMiddleware class must be redesigned.

• This class should be removed at all in favor of WebSocketMiddleware by Microsoft .NET team.
• This class should be redesigned based on WebSocketMiddleware by Microsoft .NET team.

Actual Behavior / Motivation for New Feature

The UseWebSocketsProxyMiddleware method enables custom WebSocketsProxyMiddleware in the pipeline. But there is no usage of native WebSocketMiddleware class which is industry standard. But instead of standard framework middleware a custom WebSocketsProxyMiddleware class was written with custom Invoke method. This is design issue...

Links

• WebSocketMiddleware Class | Microsoft.AspNetCore.WebSockets | Microsoft Learn
• Source code in commits: https://github.com/ThreeMammals/Ocelot/commit/fa179bf487b8951062df8c4ba71af399ce4e5fb1, https://github.com/ThreeMammals/Ocelot/commit/ab2944234d0ff258d548bf9b7030eaf25f271226
• Websockets feature docs

Specifications

• Version: latest, 19.x & .NET 7

[raman-m]

One more concern

• 1040

[raman-m]

TODO

Pick up this ticket only after

• [ ] .NET 9 Release in November 2024
• [ ] Ocelot upgrade to net9.0