Closed raman-m closed 11 months ago
@ggnaegi FYI As we agreed on PR 1670 merging I've created this PR.
@RaynaldM Hey, Ray! I will appreciate your review and approval ASAP. Thank you!
@ggnaegi FYI As we agreed on PR 1670 merging I've created this PR.
@raman-m I could review it...Because most of it is not my code.
@ggnaegi Your approval will have gray status which means it does not approve the PR actually and uncover PR status to merge. But your opinion is welcomed! I could even fix something if you judge my code 😉
@ggnaegi Will you review? Is it Okay to merge?
@ggnaegi Will you review?
@raman, yes sure, probably in the afternoon...
@RaynaldM Sorry, there will be a number of code review commits... Wait for my next message please!
@ggnaegi I've resolved issues of your code review! Are we done?
@RaynaldM I'm sorry that I dismissed your approvals multiple times! Make a final approval, plz 🙏
4 :star::star::star::star: to Raman Maksimchuk 🥇 3 :star::star::star: to jlukawska 🥈 2 :star::star: to Guillaume Gnaegi 🥉
1st :1st_place_medal: goes to Raman Maksimchuk for delivering 4 commits 2nd :2nd_place_medal: goes to jlukawska for delivering 3 commits 3rd :3rd_place_medal: goes to Guillaume Gnaegi for delivering 2 commits in 2 files changed 3rd :3rd_place_medal: goes to Ben Bartholomew for delivering 1 feature in 3 files changed with 83 insertions 3rd :3rd_place_medal: goes to Guillaume Gnaegi for delivering 1 feature in 3 files changed with 13 insertions and with 422 deletions
:star::star::star::star: Raman Maksimchuk :star::star::star: jlukawska :star::star: Guillaume Gnaegi :star: Anthony Steele :star: Ben Bartholomew :star: DanHarltey :star: Fabrizio Mancin :star: Freddy :star: Kevin Grossmann :star: Marco, Roman, Thiago Loureiro, Vijay Karavadra, guoyongchang, leonluc-dev, raman-m, zhangq
1st :1st_place_medal: goes to DanHarltey for delivering 1 feature in 8 files changed 2nd :2nd_place_medal: goes to Ben Bartholomew for delivering 1 feature in 3 files changed with 83 insertions 3rd :3rd_place_medal: goes to Guillaume Gnaegi for delivering 1 feature in 3 files changed with 13 insertions and 422 deletions
1st :1st_place_medal: goes to raman-m for delivering 7 features 2nd :2nd_place_medal: goes to Raman Maksimchuk for delivering 4 features 3rd :3rd_place_medal: goes to jlukawska for delivering 3 features
:star::star::star::star::star::star::star: raman-m :star::star::star::star: Raman Maksimchuk :star::star::star: jlukawska :star::star: Guillaume Gnaegi :star: Anthony Steele :star: Ben Bartholomew :star: DanHarltey :star: Fabrizio Mancin :star: Freddy :star: Kevin Grossmann :star: Marco :star: Roman :star: Thiago Loureiro :star: Vijay Karavadra :star: guoyongchang :star: leonluc-dev :star: zhangq
deleted
Relates to #1670
This is follow up PR after merging of PR #1670
1670
Proposed Changes