search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.38k stars 1.64k forks source link

#1712 Bump to Polly 8.0 #1714

Closed RaynaldM closed 1 year ago

RaynaldM commented 1 year ago

Closes #1712

Bump to Polly 8.0 and some code improvements

raman-m commented 1 year ago

@RaynaldM Is it urgent or not? Are you experiencing some problems with current /old version of Polly package in the project of your team?

I'm afraid it will be wrong to add this change to current release because of the package upgrading. Let me know the urgency plz...

RaynaldM commented 1 year ago

@raman-m commented on Oct 2

@raman-m no urgency currently

raman-m commented 1 year ago

@RaynaldM commented on Oct 2

👌 I'm focusing on the release now...

raman-m commented 1 year ago

Don't worry about failed build 2086, this is Scenario: Open circuit should not effect different route Next build should have green status. This is well-known bug-issue #1706 :

@ggnaegi Hi! As you see, this test is constantly failing, rare, but it fails. It seems we need to prioritize #1706 as High 😉 Do you have some time this week to spare on the bug?

raman-m commented 1 year ago

⚠️ Ray, You are the member of the team. You can create feature branches right in this ThreeMammals/Ocelot repository 😉 I've rebased the feature branch. The build is green now.

raman-m commented 1 year ago

Ray, I have refactored two classes. Are you OK with these changes?

raman-m commented 1 year ago

@RaynaldM Are we going to merge? 😃

RaynaldM commented 1 year ago

Ray, I have refactored two classes. Are you OK with these changes?

Yes, I'm

raman-m commented 1 year ago

@RaynaldM Yes, I'm

How would you like to reuse this feature in your projects? Is it urgent to release? Or are you building a local Ocelot solution from develop branch of your forked repo?

RaynaldM commented 1 year ago

We've released a 20.0.1-alpha on our artifacts repo, so we're in no hurry, it's still in the test phase. We're sticking as closely as possible to the original Ocelot, and will continue to do so for as long as possible. So, we sometimes make temporary "alpha (or beta)" packages (e.g. migration to .Net 7) while waiting for integration into the official package.

raman-m commented 1 year ago

@RaynaldM commented on Oct 16 We've released a 20.0.1-alpha on our artifacts repo, so we're in no hurry, it's still in the test phase... ...waiting for integration into the official package.

👌 We will have 20.0.1 official release these days because of ReadTheDocs build problem (the fix is merged into release/20.0 branch already). If you want, I can include your feature from develop? Otherwise, you & your team will have to wait until the first days of November for the October's release.

RaynaldM commented 1 year ago

as you want @raman-m, for us, it's ok for begining of November