adding read the docs yaml config file

ThreeMammals / Ocelot

.NET API Gateway

https://www.nuget.org/packages/Ocelot

MIT License

8.32k stars 1.63k forks source link

adding read the docs yaml config file #1732

Closed ggnaegi closed 11 months ago

ggnaegi commented 11 months ago

Fixes / New Feature #1731

Proposed Changes

add .readthedocs.yaml file to the root folder. https://blog.readthedocs.com/migrate-configuration-v2/

I just tried myself https://ocelot-test.readthedocs.io/en/latest/features/authentication.html

@raman-m it seems too easy, no?

raman-m commented 11 months ago

Wow! Thank you for caring about our project during your weekend!

I've planned to work on docs recovery after the release, but as usual I had no time for that. It seems you beat me.

Question

What branch you've created the feature branch from? In my opinion it should be hotfix. So, we have to use current release branch release/20.0 or main one. But release branch is better choice.

ggnaegi commented 11 months ago

Wow! Thank you for caring about our project during your weekend!

I've planned to work on docs recovery after the release, but as usual I had no time for that. It seems you beat me.

Question

What branch you've created the feature branch from? In my opinion it should be hotfix. So, we have to use current release branch release/20.0 or main one. But release branch is better choice.

@raman-m I used the develop branch. I can delete the current PR and create a new one based on branch release/20.0

raman-m commented 11 months ago

Yes, please close! We can't wait till the next major release of features in develop. So, it will be a hotfix for the 20.0 release.

Create feature branch from release/20.0 one please!

And, please create a bug issue with explanation of the problem, and how to fix. I've skipped to do that previous week. Probably we will have a longer discussion of the problem than expected. Thanks!

ggnaegi commented 11 months ago

@raman-m as discussed, closing the PR