ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.38k stars 1.64k forks source link

#1093 Add Retry mechanism based on Polly #1770

Closed ks1990cn closed 1 year ago

ks1990cn commented 1 year ago

Closes #1093

This is proposed solution to add WaitAndRetry mechanism of Polly, which is currently not part of Polly (QoS).

This is not proper solution, this just I am trying to understand high level changes we need to add WaitAndRetry. I have not done any refactoring.

Proposed Changes

raman-m commented 1 year ago

@ks1990cn

Can we discuss on https://github.com/ThreeMammals/Ocelot/issues/1093 with this proposed solution?

Sure! I propose to remove Polly from Ocelot at all!... Because Polly is a constant source of issue/bugs being reported in our backlog.

raman-m commented 1 year ago

Dear Tanmay, Make it ready for review! Could you resolve all merge conflicts please?

ks1990cn commented 1 year ago

Dear Tanmay, Make it ready for review! Could you resolve all merge conflicts please?

But I thought you guys are going to remove Polly. do I still need to resolve, cause its incomplete PR just had suggestion on it.

raman-m commented 1 year ago

But I thought you guys are going to remove Polly.

Not now. It was a joke! 🤣 Polly removal is not discussed at the moment. It is just my idea to have less dev pain in the neck... At least next 2 major Ocelot releases will have Polly lib being referenced definitely...