Closed RaynaldM closed 10 months ago
For "should_be_invalid_re_route_using_downstream_http_version" UT, I noticed that the message changes depending on the OS language. So, I have changed it, and I fix ThenTheErrorsContains method so that it makes "Contains" and not "Equal".
@RaynaldM commented on Nov 17:
For
should_be_invalid_re_route_using_downstream_http_version
UT, I noticed that the message changes depending on the OS language.
Really? 🤣 Surprise from France!
For "should_be_invalid_re_route_using_downstream_http_version" UT, I noticed that the message changes depending on the OS language. So, I have changed it, and I fix ThenTheErrorsContains method so that it makes "Contains" and not "Equal".
Funny, I remember having seen this one, I thought it was fixed 🤣
@ggnaegi Sorry for being late! I see you cannot wait for release commits from main branch 😄 OK! Going to deliver release/net8 commits to develop...
@ggnaegi Watch for #1798 merging please to rebase current feature branch
it's not me, @RaynaldM merged it 😸
Ups, my fault! This PR is Raynald's one! 🤣 Actually #1798 is merged. So, Ray should rebase this feature branch... If he won't, then I will help in Nov'23 )))
Ups, my fault! This PR is Raynald's one! 🤣 Actually #1798 is merged. So, Ray should rebase this feature branch... If he won't, then I will help in Nov'23 )))
merge done
QoS docs? https://ocelot.readthedocs.io/en/latest/features/qualityofservice.html It seems PR doesn't affect docs...
@RaynaldM If you don't mind, I delete the feature branch...
Proposed Changes
Remove try/catch in PollyPoliciesDelegatingHandler Add a more generic AddPolly to be able to use a specific PollyQoSProvider