#1787 Upgrade to .NET8 - Githubissues

ThreeMammals / Ocelot

.NET API Gateway

https://www.nuget.org/packages/Ocelot

MIT License

8.32k stars 1.63k forks source link

#1787 Upgrade to .NET8 #1788

Closed ggnaegi closed 10 months ago

ggnaegi commented 10 months ago

Closes #1787

1787

Proposed Changes

Upgrading solution to .NET 8
Base projects targeting .NET 7 too, allowing backward compatibility
Several fixes, such as VersionPrefix, using append method for headers etc.

ggnaegi commented 10 months ago

@raman-m Ok, you have a first version, the build pipeline is complaining about .NET 8 not being supported.

raman-m commented 10 months ago

Great! But... 😆 Let's discuss on Monday when Ray will be online in Slack...

raman-m commented 10 months ago

ggnaegi:features/1787_upgrade_to_dot_net_8 What branch did you create this one from?

Important note❗

raman-m commented 10 months ago

into ThreeMammals:develop

No! We've decided to make a separate release as a hotfix. PR must be merged to main or release/net8 ! The 2nd is preferable

What branch did you create feature one from? Please, rebase feature branch onto release/net8!

raman-m commented 10 months ago

Title

1787 Upgrade to .NET8 #1788

We're lucky! 😄 We have a lot of 8️⃣

raman-m commented 10 months ago

The comparing diff contains commits from develop! That means you've created feature branch from develop. Please, rebase feature branch onto release/net8! We have to follow Hotfix process!

ggnaegi commented 10 months ago

So I will close this PR reopen a new one based on the release branch you mentionned.