#1787 Upgrade to .NET 8

ThreeMammals / Ocelot

.NET API Gateway

https://www.nuget.org/packages/Ocelot

MIT License

8.32k stars 1.63k forks source link

#1787 Upgrade to .NET 8 #1789

Closed ggnaegi closed 10 months ago

ggnaegi commented 10 months ago

Closes #1787

1787

Proposed Changes

Targeting frameworks net6.0, net7.0, net8.0
Using C# Preprocessor when needed
Tests and Samples should target net6.0;net7.0;net8.0 too
Updating .editorconfig, making sure we are using 2 white spaces for indentation in .xml files

raman-m commented 10 months ago

Did you sleep this night? 😮

raman-m commented 10 months ago

Main concern! You tried to unite all changes into one PR... But we have to make new Docker image first to prepare CircleCI pipeline... After that we can update projects... Are you still sure to merge one PR?

ggnaegi commented 10 months ago

Main concern! You tried to unite all changes into one PR... But we have to make new Docker image first to prepare CircleCI pipeline... After that we can update projects... Are you still sure to merge one PR?

Yes! It was already quite something, all tests are passing locally.

ggnaegi commented 10 months ago

OK... Good job! 👍 I see the following gaps:

Changed C# files even there is no C# preprocessor directive

Don't change source & tests! Only .csproj files! And required for migration.

Some proj-files have bad formatting as changes but it seems tabs were not replaced with spaces

I did only changes when warnings were prompted or build failed.

ggnaegi commented 10 months ago

@raman-m fine for me as soon as the docker image is available 😹