search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.38k stars 1.64k forks source link

Add Global Configuration to ocelot.json file in AddOcelot function #1794

Closed ali0saeedi closed 11 months ago

ali0saeedi commented 11 months ago

Expected Behavior / New Feature

If global configuration is added to the config folder we expect the config will copy to the aggregated ocelot.json file.

Actual Behavior / Motivation for New Feature

In the global configuration section, null values will be inserted in ocelot.josn file.

Steps to Reproduce the Problem

  1. add global configuration instructions to the AddOcelot function in Ocelot.DependencyInjection

Specifications

ali0saeedi commented 11 months ago

you should name your config file to ocelot.global.json in config folder

raman-m commented 11 months ago

Dear Ali, We don't understand your user scenario! No information on environment. Ocelot is based on and optimized for Docker deployments and scaling...

We cannot accept this feature request! If this is a bug, provide more details on the user scenario please!

I recommend to discuss your user scenario first in Discussion space.

Formally you violated development process because it is not discussed, and your GitHub account has no Ocelot as forked repo.

raman-m commented 11 months ago

@ali0saeedi commented on Nov 21:

you should name your config file to ocelot.global.json in config folder

Learn more: Merging Configuration Files