#479 UpstreamPathTemplate hard-coded priority 0

ThreeMammals / Ocelot

.NET API Gateway

https://www.nuget.org/packages/Ocelot

MIT License

8.31k stars 1.63k forks source link

#479 UpstreamPathTemplate hard-coded priority 0 #1908

Closed AlyHKafoury closed 8 months ago

AlyHKafoury commented 8 months ago

Fixes #479

Proposed Changes

Fix UpstreamPathTemplate hard-coded priority 0 : Change the priority during a template path "{" to be route.Priority

AlyHKafoury commented 8 months ago

Closes #479

AlyHKafoury commented 8 months ago

raman-m, I have a test case where the Priority is ignored for the catchall in here https://github.com/ThreeMammals/Ocelot/blob/bb795876c493af958f1d58c852ea56e94263906d/test/Ocelot.UnitTests/Configuration/UpstreamTemplatePatternCreatorTests.cs#L51 should I change this test case because ignoring the priority is not the required behavior anymore ?

raman-m commented 8 months ago

@AlyHKafoury commented on Jan 8:

should I change should_use_zero_priority test case because ignoring the priority is not the required behavior anymore ?

No, you will break current Catch All Priority feature which should have lowest 0 priority! I believe you need to make an exception for CatchAll case allowing 0 for CatchAll route. Then this test will turn green.