The most significant changes involve updates to the OcelotBuilderExtensions and PollyQoSResiliencePipelineProvider classes, as well as modifications to the PollyQoSTests class.
In the OcelotBuilderExtensions class, the GetDelegatingHandler method is now used instead of GetDelegatingHandlerV7 in the AddPolly methods. The AddPolly method without parameters has been simplified using a lambda expression. The GetDelegatingHandler method now returns a new instance of PollyResiliencePipelineDelegatingHandler instead of PollyPoliciesDelegatingHandler.
In the PollyQoSResiliencePipelineProvider class, a comment has been added suggesting the use of ResiliencePipelineRegistry<TKey>.GetOrAddPipeline due to its thread-safe nature. The MinimumThroughput property in circuitBreakerStrategyOptions now uses the value from route.QosOptions.ExceptionsAllowedBeforeBreaking.
In the PollyQoSTests class, the QoSOptions used in the test configurations have been updated. Two tests, Should_open_circuit_breaker_then_close and Open_circuit_should_not_effect_different_route, have been modified to repeat the same request as the minimum ExceptionsAllowedBeforeBreaking is now 2. The GivenThereIsAPossiblyBrokenServiceRunningOn method now delays for 2.1 seconds when the request count is 2, to ensure the circuit is open.
Proposed Changes
OcelotBuilderExtensions class updated to use GetDelegatingHandler method.
AddPolly methods in OcelotBuilderExtensions class simplified.
GetDelegatingHandler method in OcelotBuilderExtensions class now returns a new instance of PollyResiliencePipelineDelegatingHandler.
Comment added in PollyQoSResiliencePipelineProvider class suggesting the use of ResiliencePipelineRegistry<TKey>.GetOrAddPipeline.
MinimumThroughput property in circuitBreakerStrategyOptions updated to use value from route.QosOptions.ExceptionsAllowedBeforeBreaking.
QoSOptions in PollyQoSTests class updated.
Should_open_circuit_breaker_then_close and Open_circuit_should_not_effect_different_route tests in PollyQoSTests class updated.
GivenThereIsAPossiblyBrokenServiceRunningOn method in PollyQoSTests class updated to delay for 2.1 seconds when request count is 2.
Fixes / New Feature #
The most significant changes involve updates to the
OcelotBuilderExtensionsandPollyQoSResiliencePipelineProviderclasses, as well as modifications to thePollyQoSTestsclass.In the
OcelotBuilderExtensionsclass, theGetDelegatingHandlermethod is now used instead ofGetDelegatingHandlerV7in theAddPollymethods. TheAddPollymethod without parameters has been simplified using a lambda expression. TheGetDelegatingHandlermethod now returns a new instance ofPollyResiliencePipelineDelegatingHandlerinstead ofPollyPoliciesDelegatingHandler.In the
PollyQoSResiliencePipelineProviderclass, a comment has been added suggesting the use ofResiliencePipelineRegistry<TKey>.GetOrAddPipelinedue to its thread-safe nature. TheMinimumThroughputproperty incircuitBreakerStrategyOptionsnow uses the value fromroute.QosOptions.ExceptionsAllowedBeforeBreaking.In the
PollyQoSTestsclass, theQoSOptionsused in the test configurations have been updated. Two tests,Should_open_circuit_breaker_then_closeandOpen_circuit_should_not_effect_different_route, have been modified to repeat the same request as the minimumExceptionsAllowedBeforeBreakingis now 2. TheGivenThereIsAPossiblyBrokenServiceRunningOnmethod now delays for 2.1 seconds when the request count is 2, to ensure the circuit is open.Proposed Changes
OcelotBuilderExtensionsclass updated to useGetDelegatingHandlermethod.AddPollymethods inOcelotBuilderExtensionsclass simplified.GetDelegatingHandlermethod inOcelotBuilderExtensionsclass now returns a new instance ofPollyResiliencePipelineDelegatingHandler.PollyQoSResiliencePipelineProviderclass suggesting the use ofResiliencePipelineRegistry<TKey>.GetOrAddPipeline.MinimumThroughputproperty incircuitBreakerStrategyOptionsupdated to use value fromroute.QosOptions.ExceptionsAllowedBeforeBreaking.QoSOptionsinPollyQoSTestsclass updated.Should_open_circuit_breaker_then_closeandOpen_circuit_should_not_effect_different_routetests inPollyQoSTestsclass updated.GivenThereIsAPossiblyBrokenServiceRunningOnmethod inPollyQoSTestsclass updated to delay for 2.1 seconds when request count is 2.