search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.28k stars 1.63k forks source link

Fix typo in the name of the `DistributedCacheRateLimitCounterHandler` class #1969

Closed williamscs closed 6 months ago

williamscs commented 6 months ago

Proposed Changes

This fixes a typo in a class name.

raman-m commented 6 months ago

LoL 🤣 Thank you, Chris, for your eagle eye! 🦅

raman-m commented 6 months ago

Have you ever heard about obfuscation technology? 😉 😆

raman-m commented 6 months ago

I can't get it... Why are there no references in DI? The class is defined, but not used in the solution... 🤯 Seems this is very old Tom's idea, and not finished feature...

williamscs commented 6 months ago

I can't get it... Why are there no references in DI? The class is defined, but not used in the solution... 🤯 Seems this is very old Tom's idea, and not finished feature...

I only found it because of this issue: https://github.com/ThreeMammals/Ocelot/issues/609

I believe the intent is that it isn't used within the repo (though maybe it needs tests). I think you're supposed to instantiate yourself it in order to support rate limiting across multiple replicas. I was going to test it out this week or next.

raman-m commented 6 months ago

OK Do you use Redis Cache or something else?