#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior

ThreeMammals / Ocelot

.NET API Gateway

https://www.nuget.org/packages/Ocelot

MIT License

8.35k stars 1.63k forks source link

#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior #2081

Open RaynaldM opened 4 months ago

RaynaldM commented 4 months ago

Closes #2080

2080

This PR adds 2 new parameters in QoSOptions to fine-tune circuit-breaker behavior 👉

FailureRatio: The failure-success ratio that will cause the circuit to break/open.
SamplingDuration: The time period over which the failure-success ratio is calculated (in seconds).

raman-m commented 4 months ago

Great! Which version are you planning to release it in?

Please note that the PR depends on #2073, which needs to be merged before this PR. Therefore, this feature branch should be rebased after the merging of #2073, and ideally, after #2079 is merged as well.

It appears that it won't be included in version 23.3, but rather in version 24.0, which is the next release following v23.3. Is this delivery acceptable to you?

RaynaldM commented 4 months ago

Great! Which version are you planning to release it in?

Please note that the PR depends on #2073, which needs to be merged before this PR. Therefore, this feature branch should be rebased after the merging of #2073, and ideally, after #2079 is merged as well.

It appears that it won't be included in version 23.3, but rather in version 24.0, which is the next release following v23.3. Is this delivery acceptable to you?

Yes, @raman-m, you can add this when you want

raman-m commented 3 months ago

@RaynaldM Please resolve conflicts! PR has been added to v24.0 milestone, current release

raman-m commented 3 months ago

@RaynaldM Conflicts!

raman-m commented 1 month ago

Let's assign this to the Sep'24 milestone since the Annual 2023 milestone is already quite overloaded, and we need to reduce the scope of work for 2023.