Closed EngRajabi closed 1 month ago
Mohsen, thank you for the nice PR. However, I've noticed some instability in the CircleCI jobs on the feature branch, which seems to stem from issues in the develop branch. It's important to adhere to our development process by not creating feature branches from a broken develop branch.
1) Could you align your develop branch with the ThreeMammals/Ocelot:develop branch? Your develop branch is currently 13 commits ahead of the ThreeMammals/Ocelot:develop, but there should be no differences. Your develop branch contains numerous Merge branch 'ThreeMammals:develop' into develop
commits, which are causing instability in our CircleCI builds. The quickest solution would be to delete the develop branch and then recreate it, ensuring it's fully synchronized with the head repository. If the branch is protected, please unprotect it, possibly making the main branch protected instead. If this process is too complex, consider adding me as a collaborator to your forked repository, and I will address the issue.
2) After aligning the develop branch with the head repository, it's necessary to rebase your feature branch due to several issues:
Once these issues are resolved, we can commence the discussion on the feature.
In this request, we deleted the newtonsoft package and migrated to text json system. The reason for the changes
@MohammadAminPourmoradian helped me with this
BenchmarkDotNet v0.13.11, Windows 11 (10.0.22631.3880/23H2/2023Update/SunValley3) Intel Core i7-10870H CPU 2.20GHz, 1 CPU, 16 logical and 8 physical cores .NET SDK 8.0.303 [Host] : .NET 6.0.32 (6.0.3224.31407), X64 RyuJIT AVX2 [AttachedDebugger] .NET 8.0 : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX2
Job=.NET 8.0 Runtime=.NET 8.0