search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.31k stars 1.63k forks source link

#746 Multiple values in static claims #2131

Open asrasya-kosha opened 1 month ago

asrasya-kosha commented 1 month ago

Closes #746

Proposed Changes

Note : The proposed changed will only work for static claims. There shouldn't be any effect on the dynamic claims.

raman-m commented 1 month ago

Thank you for the PR! Please note that the development process mandates the inclusion of both unit and acceptance tests for every new feature and bug fix. New features should be accompanied by tests that cover the new functionality. Additionally, merely fixing existing tests does not suffice to warrant approval of the PR.

ggnaegi commented 1 month ago

@raman-m reviewing it right now...

raman-m commented 1 month ago

@ggnaegi reviewed on Aug 8

Thanks for code review! But you know I will return to feature PRs after v23.3 Hotfixes release. Also this PR has a lot of fake changes probably because of line endings problem so it's hard to read real changes.

asrasya-kosha commented 3 weeks ago

Thank you for the PR! Please note that the development process mandates the inclusion of both unit and acceptance tests for every new feature and bug fix. New features should be accompanied by tests that cover the new functionality. Additionally, merely fixing existing tests does not suffice to warrant approval of the PR.

@raman-m I'll add acceptance tests and new unit tests (I thought I added them but I'll have a look once again) this weekend and update the PR. The line ending changes are perhaps a GitHub issue? because I don't see them in rider when I do sa side by side compare. Thanks

raman-m commented 1 week ago

@asrasya-kosha Please work on code review issues. Also, we have to add at least one acceptance test.

raman-m commented 1 week ago

@asrasya-kosha commented on Aug 20, 2024

The line ending changes are perhaps a GitHub issue?

The changes in line endings are not due to GitHub; rather, they are caused by your IDE. GitHub simply identifies the different line endings and highlights those lines.

because I don't see them in Rider when I do so side by side compare.

We have Visual Studio IDE settings for line endings here: .editorconfig#L19-L21 (common settings), *.{cs,vb} (C# CRLF ending). However, there is no settings file for Rider IDE. The main issue is the .gitattributes file for Git, which means our settings do not override EOL and commits are made as-is (both CRLF for Windows and LF for Linux). Local/global Git settings may sometimes override EOL in this file. Since you're using Rider IDE, ensure that your Git environment does not override EOL (a mixed mode is preferred).