search

ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.32k stars 1.63k forks source link

Strong-named binaries #399

Open davidni opened 6 years ago

davidni commented 6 years ago

Expected Behavior / New Feature

Ocelot binary (ocelot.dll) is not strong-named

Actual Behavior / Motivation for New Feautre

Ocelot cannot currently be consumed from strong-named projects. Projects that are strong-named must reference only strong-named dependencies, so Ocelot would have to be strong-named too,

Specifications

davidni commented 6 years ago

Note that in order to do this, the first step would be to produce strong-named versions of Ocelot dependencies. I see 5 problematic ones:

Rafty should be easy to tackle. Not sure about the others.

TomPallister commented 6 years ago

@davidni this is something we could look at one day but not anytime soon given the dependencies.

raman-m commented 9 months ago

Zero benefit, in my opinion!

@davidni Show us at least one user /contributor who will make their web app assemblies strong-named? Maybe Microsoft will re-use Ocelot.dll in products as strong-named assembly? 🤣

But from other side, Ocelot is distributed through public channels like NuGet, so we need to make Ocelot.dll strong-named. Well... It is dilemma!