ThreeMammals / Ocelot

.NET API Gateway
https://www.nuget.org/packages/Ocelot
MIT License
8.32k stars 1.63k forks source link

support netcoreapp2.1 #454

Closed TomPallister closed 6 years ago

TomPallister commented 6 years ago

Expected Behavior / New Feature

support netcoreapp2.1

Actual Behavior / Motivation for New Feautre

when using netcoreapp2.1 Ocelot uses tons of memory that grows exponentially.

Steps to Reproduce the Problem

  1. Upgrade Ocelot project to netcoreapp2.1
  2. Hit with lots of traffic
  3. Cry

Specifications

TomPallister commented 6 years ago

blocked by appveyor not support sdk 2.1.301

TomPallister commented 6 years ago

can be merged after performance issues are sorted

TomPallister commented 6 years ago

standard asp.net core 2.1 web api project, 10000 requests with 100 concurrency normal-asp-net-web-api-10000r-100c

Ocelot asp.net core 2.0 ocelot-asp-net-2-web-api-10000r-100c web api project, 10000 requests with 100 concurrency

Ocelot asp.net core 2.0 ocelot-asp-net-21-web-api-10000r-100c

Everything seems stable when hosted on azure app service (windows + iis) or at least no worse than 2.0

TomPallister commented 6 years ago

normal asp.net 2.1 webapi handles 10000 requests 100 concurrency normal-asp-net-21-web-api-handles-10000r-100c

ocelot asp.net 2.1 webapi handles 10000 requests 100 concurrency ocelot-asp-net-21-web-api-handles-10000r-100c

TomPallister commented 6 years ago

think this is OK to merge as performance seems similar to that of normal web api....

TomPallister commented 6 years ago

Released in 8.0.0