ThreeSixes / airSuck

AirSuck is an ADS-B/SSR and AIS processing, storage, and display application with Google Maps integration.
GNU General Public License v3.0
9 stars 4 forks source link

leaflets map #26

Open rhaamo opened 6 years ago

rhaamo commented 6 years ago

hello,

I worked a long time ago on using Leaflets instead of Google Maps on my branch¹ and it works more-or-less good, except an issue where sometimes some markers are created without a lat/lon (which is something gmaps accepts, not leaflet) and some markers with lat/lon aren't created properly even with lat/lon. (yeah I'm stuck at this point and I cannot figure why this behaviour)

That's the current state and I haven't much used it a lot (I moved house in the mean time so I lost interest on it at this time).

Are you interested on continuing this migration ? There is some benefits on using leaflets and I may restart to look on how to improve that if there is interest.

¹ https://github.com/rhaamo/airSuck/tree/fixes

ThreeSixes commented 6 years ago

I'm down to keep this going if you are. I'm also getting ready for some big changes, but if you want to keep this going I'm in.

rhaamo commented 6 years ago

Sorry for not replying sooner. Now with the whole gmaps api situation I think leaflets is the way to go. I haven't touched my branch since a long time, and as stated in the first post it more-or-less works, with some issues. This part is the one where I have the less knowledge and not familiar with, and actually I don't know if I will be able to fully resolve issues with my implementation.

mjlurbanist commented 6 years ago

We haven’t gotten into it in awhile either. Correct with gmaps at this point. I also started using mapbox which I’ve found to be very easy to manipulate for other projects. Good reminder on Leaflet though, may be useful as an alternative for those mapbox projects too.

On Aug 14, 2018, at 2:56 AM, Marc Lagrange notifications@github.com wrote:

Sorry for not replying sooner. Now with the whole gmaps api situation I think leaflets is the way to go. I haven't touched my branch since a long time, and as stated in the first post it more-or-less works, with some issues. This part is the one where I have the less knowledge and not familiar with, and actually I don't know if I will be able to fully resolve issues with my implementation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ThreeSixes/airSuck/issues/26#issuecomment-412819151, or mute the thread https://github.com/notifications/unsubscribe-auth/ANbxqVfUD3xgEsEzmDBqwH3MRFDErg1Pks5uQp7HgaJpZM4R96ou.

rhaamo commented 6 years ago

I never used mapbox, only leaflets on other projects. On the current implementation of leaflets in airSuck I also use Leaflets Providers to have various maps (Black and white, OSM, OpenTopo, Stamen Terrain or even Esri ocean basemap, with a togglable overlay of OpenSeaMap). Leaflets Providers can also use mapbox maps but same, never used. I will anyway re-setup airSuck one of thoses days because I can receive AIS where I live. I will see if I can go further in debugging the current issues.