search

ThreeSixtyGiving / 360-ds

360Giving Design System - Components
https://cdn.threesixtygiving.org/
2 stars 1 forks source link

updates colors page with text safe options #18

Closed claudioccm closed 3 years ago

claudioccm commented 3 years ago

@drkane, I updated the color swatches page to incorporate the accessible colors for text. I think the production branch of your repo is a bit behind the master, so let me know if you wanna go through this PR together. Cheers man

drkane commented 3 years ago

Hi Claudio - thanks, looks great. You're right that the production versions have got out of sync with this version, I can try and fix that once the PR is agreed.

I think there's a few places where the new colours aren't being brought through from the css variables. Eg a search for color: $teal; finds a few places where the new styles aren't applied to things like a tags in the prose sections:

https://github.com/ccmdesign/360-ds/blob/51db9c8b8a8cfcb967446d79b7acda889ccf7bec/src/components/04-modules/prose/prose.scss#L22-L25

Could we check that all the places where color has been specified are using the text colours?

drkane commented 3 years ago

Thanks - looks great!