search

ThreeSixtyGiving / 360-ds

360Giving Design System - Components
https://cdn.threesixtygiving.org/
2 stars 1 forks source link

src: project-styles: insights: custom: add underline-text #58

Closed BibianaC closed 2 years ago

BibianaC commented 2 years ago

Making links more visible. Relates to https://github.com/ThreeSixtyGiving/insights-ng/issues/70

If we use what we have in the design system it would increase the font and move the paragraph to the right.

Screen Shot 2022-02-14 at 10 39 16

Or

Screen Shot 2022-02-14 at 10 38 50

I propose keep the font as we have it now and to add a custom underline:

Screen Shot 2022-02-14 at 10 28 54
mariongalley commented 2 years ago

If we use what we have in the design system it would increase the font and move the paragraph to the right.

Hmm, that's very strange

I propose keep the font as we have it now and to add a custom underline:

I agree this is definitely better than the screenshots above - I am curious though about whether we can modify the design system to it works with this style of card and supports the left-alignment? It would be best to use the design system if possible, but if not then the solution above looks good too.

BibianaC commented 2 years ago

Thanks, @mariongalley .

BibianaC commented 2 years ago

Fixed in https://github.com/ThreeSixtyGiving/insights-ng/commit/df97f0d83669e9568be1e33b9c3a0d19e08fc3e5