search

ThreeSixtyGiving / 360-ds

360Giving Design System - Components
https://cdn.threesixtygiving.org/
2 stars 1 forks source link

components: cookie-consent: fix padding and position #62

Closed BibianaC closed 2 years ago

BibianaC commented 2 years ago

This PR fixes the text being outside the box and the position.

The box is transparent and it is difficult to read the text. Is that okay?

Screen Shot 2022-03-18 at 15 21 08
michaelwood commented 2 years ago

This PR fixes the text being outside the box and the position.

The box is transparent and it is difficult to read the text. Is that okay?

Having the text overlay like this wouldn't provide a good user experience, It looks like a problem with the z-index modals/dialog need to be placed above everything else.

We also need to resolve #63

BibianaC commented 2 years ago

@michaelwood background is now fixed.

Screen Shot 2022-03-23 at 13 42 57

We can resolve #63 in another PR.

BibianaC commented 2 years ago

Dialog in https://github.com/ThreeSixtyGiving/360-ds/pull/64

michaelwood commented 2 years ago

Lovely, could we also have the [z-index: 99](https://developer.mozilla.org/en-US/docs/Web/CSS/z-index) set just to make sure it is always above all other elements on a page.

BibianaC commented 2 years ago

@michaelwood I have added the index