ThreeSixtyGiving / 360insights

GrantVis - Visual 360Giving Data explorer
https://grantvis.threesixtygiving.org
GNU General Public License v3.0
0 stars 0 forks source link

Change copy on lozenge for Award Dates #218

Open mariongalley opened 11 months ago

mariongalley commented 11 months ago

New Insights has slightly lengthier copy which is unnecessary (also not always accurate, as min-max is included even if only one of min or max is applied). Please update to match live Insights

New Insights copy: "Award date min - max"

Live Insights copy: "Award dates"

michaelwood commented 10 months ago

Ah I did add that because there are two filters and I wanted to make it clearer which one was applied. (selecting a year, vs setting a min-max) technically you can do both so would end up with two "Award date" filter lozenge. This is the GrantNav equivalent e.g. https://grantnav.threesixtygiving.org/search?query=%2A&default_field=%2A&sort=_score+desc&min_amount=300&max_amount=50000&awardDate=2019

mariongalley commented 10 months ago

Ah right, that makes sense, thanks @michaelwood Although I found that if I first selected an award date and then added a min-max it didn't override the lozenge

michaelwood commented 10 months ago

correction to GN url - https://grantnav.threesixtygiving.org/search?query=%2A&default_field=%2A&sort=_score+desc&min_date=10%2F2014&max_date=11%2F2019&awardDate=2019

GrantNav you can get into quite a mess, and annoyingly it hides the year selector afterwards. I think ideally in both GrantNav and Insights I would only allow one type of the two kinds of date (or amount) filters to be applied at any one time, however the UX of that would need properly thinking through.

mariongalley commented 10 months ago

Agreed @michaelwood - not a blocker to live in any case