Closed morchickit closed 5 years ago
drkane
commented
5 years ago This is actually already fixed (in 11760728e471da41e808aef889a5ab8647357a69) - but I hadn't reloaded the data with the new process so the error was still present in the file.
I've reloaded the two files mentioned above with duplicates - this evening when the sites not being used I will remove all existing files and reload them without the duplicates.
morchickit
commented
5 years ago Brilliant, thanks David!
On Tue, 5 Mar 2019 at 13:33, David Kane notifications@github.com wrote:
This is actually already fixed (in 1176072 https://github.com/ThreeSixtyGiving/Insights/commit/11760728e471da41e808aef889a5ab8647357a69)
- but I hadn't reloaded the data with the new process so the error was still present in the file.
I've reloaded the two files mentioned above with duplicates - this evening when the sites not being used I will remove all existing files and reload them without the duplicates.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/Insights/issues/117#issuecomment-469680834, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHzu2xwjaDyrc5qoiSANulf3H-YbErrks5vTnIpgaJpZM4belW6 .
-- Mor Rubinstein Data Labs Manager 360Giving http://www.threesixtygiving.org/ Twitter - @morchickit https://twitter.com/Morchickit Cell: +44(0)7904191881 / Office: 020 3752 5775 Skype: mor.rubinstein See grantmaking in different ways, with our new visualisation platform 360Insights https://insights.threesixtygiving.org/ 360Giving is a company https://beta.companieshouse.gov.uk/company/09668396 limited by guarantee and a registered charity http://beta.charitycommission.gov.uk/charity-details/?regid=1164883&subid=0 . Read our privacy notice http://www.threesixtygiving.org/privacy/ to find out how we collect and use personal data.
[image: cid:image001.png@01D122F0.5ED3A880]
drkane
commented
5 years ago @morchickit - could you let the user know?
morchickit
commented
5 years ago Will do!
On Tue, 5 Mar 2019 at 13:39, David Kane notifications@github.com wrote:
@morchickit https://github.com/morchickit - could you let the user know?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/Insights/issues/117#issuecomment-469682576, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHzuzcyiftaDB7fH98Kv2RraYH0gh75ks5vTnOJgaJpZM4belW6 .
-- Mor Rubinstein Data Labs Manager 360Giving http://www.threesixtygiving.org/ Twitter - @morchickit https://twitter.com/Morchickit Cell: +44(0)7904191881 / Office: 020 3752 5775 Skype: mor.rubinstein See grantmaking in different ways, with our new visualisation platform 360Insights https://insights.threesixtygiving.org/ 360Giving is a company https://beta.companieshouse.gov.uk/company/09668396 limited by guarantee and a registered charity http://beta.charitycommission.gov.uk/charity-details/?regid=1164883&subid=0 . Read our privacy notice http://www.threesixtygiving.org/privacy/ to find out how we collect and use personal data.
[image: cid:image001.png@01D122F0.5ED3A880]
KDuerden
commented
5 years ago another example of this here: https://insights.threesixtygiving.org/file/a001p00000yh5wLAAQ Should be 102 grants. Is this something that will get a global fix, or do we need to identify any affected files?
drkane
commented
5 years ago Sorry, this is my fault, I forgot to rerun all the files. Will set it going this evening when I'm at my pc.
morchickit
commented
5 years ago Can we close it now @drkane ?
For a user: "Just wanted to report a bug that we’ve noticed in the 360 Insights data analytics (https://insights.threesixtygiving.org/file/a001p000011Uot5AAC).
It’s a really exciting tool, however looking through the analysis for Trust for London and we realised that our total grant amount was off.
On further investigation of the dataset, there are duplicates for grants given to organisations that are both reg. charities and companies. All other details are the same (including the grant reference) other that this entry in the Organisation Type field. For our data there are 21 duplicates, and our total award is off by about £3m as a result. This makes quite an impact on a number of the data visualisations. I checked and the same error is present with Barrow Cadbury dataset so I think this might be an error in the import rather than the original dataset?"
@drkane - please have a look!