Footer

[jezpete]

Apologies, but looking at the Insights footer with Rachel, actually we'd prefer to replicate exactly the same layout and content as the existing website footer. Except, to add the tagline "Open data for more effective grantmaking" in the central area of the footer.

It's important that the height of the footer is minimal, so the same as existing site. Many thanks

[morchickit]

I'm a bit confused, don't we want this footer to be the base for our other sites footers? Therefore it would be aligned with the other eventually?

On Tue, 12 Feb 2019 at 13:45, Jeremy Peters notifications@github.com wrote:

Apologies, but looking at the Insights footer with Rachel, actually we'd prefer to replicate exactly the same layout and content as the existing website footer. Except, to add the tagline "Open data for more effective grantmaking" in the central area of the footer.

It's important that the height of the footer is minimal, so the same as existing site. Many thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/Insights/issues/56, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHzu2RZM6b0kV_7URXWkY5F_iHWi0LVks5vMsVcgaJpZM4a2baj .

-- Mor Rubinstein Data Labs Manager 360Giving http://www.threesixtygiving.org/ Twitter - @morchickit https://twitter.com/Morchickit Cell: +44(0)7904191881 / Office: 020 3752 5775 Skype: mor.rubinstein We are finalists for a DigitalAgenda 2019 Impact Award. Vote for us here https://www.impact-awards.co.uk/finalists! 360Giving is a company https://beta.companieshouse.gov.uk/company/09668396 limited by guarantee and a registered charity http://beta.charitycommission.gov.uk/charity-details/?regid=1164883&subid=0 . Read our privacy notice http://www.threesixtygiving.org/privacy/ to find out how we collect and use personal data.

[image: cid:image001.png@01D122F0.5ED3A880]

[jezpete]

Yes agreed. What I'm saying can apply to all sites/tools.

[morchickit]

Ok, I spoke to Rachel and I understand a bit more now. :-) @claudioccm - Can we do the following -

1. Make the footer shorter - it takes a lot of space at the bottom
2. Keep the tagline "Open data for more effective grantmaking"
3. Make tagline and logo smaller
4. Have two tows - row 1 - Contact, Support Row 2 (where the cookie policy now at the moment) - Privacy notice | Terms & Conditions| Cookie Policy | Take Down Policy | License - Created by David Kane, design by CCMdesign

[claudioccm]

@morchickit - This is the shortest I think the footer could go. More than that it will get too cluttered.

Another option, is to eliminate everything above the line, and only leave the Privacy, Cokiee, etc below it.

[drkane]

One other thing - I'd like to add the footer to the results page (some users may come straight there rather than to the homepage first). But if I include it at the bottom of the chart page it doesn't work, it ends up half way up the page under the charts. Is there some kind of clearfix that could be implemented to make sure it's at the bottom?

[claudioccm]

@drkane can you update the beta version with the footer on the charts page, so I can hack the css for you? Without the live version I can't really guess what's going on.

[drkane]

@claudioccm - should now be there, eg: http://insightsbeta.findthatcharity.uk/file/52fb5ededd6ff473ee58a4c2ab47261a

[claudioccm]

@drkane I saw how it is working. I believe the main problem is on where the footer is getting placed in the HTML structure. I have two possible solutions: 1- we add the footer as the last element of the #react-entry-point. Is that possible? This would make the weird scrolling stop. And once we have that, I can give you a quick hack of CSS styles to fix the design.

2- we don't add the footer at all, and instead, just add the links we have on the footer (mainly Privacy, Terms, and Licence) to the sidebar. I believe these are the ones you are more concerned about, correct?

[drkane]

@claudioccm - I added the footer inside the #react-entry-point and it looks great on firefox, on chrome it looks odd though. Even without the footer you get scrollbars on both sides of the page on chrome -

Scrollbars on chrome:

With footer, takes over the page - only the content is scrollable in the tiny gap, footer stays fixed to the bottom:

[morchickit]

@claudioccm -we need About, contact, Terms, Privacy, Cookies, Takedown, Creative Commons license

[morchickit]

@claudioccm - We made changes to the wording of the footer, so it's much shorter now. Is this helpful?

[claudioccm]

New footer. We will send a new commit later today