search

ThreeSixtyGiving / datagetter

Scripts to download data from http://registry.threesixtygiving.org
MIT License
1 stars 1 forks source link

requirements: Update all requirements #30

Closed odscjames closed 3 years ago

odscjames commented 3 years ago

Python 3.7 comment removed by tool - this was generated on Python 3.6, same as tests run on

michaelwood commented 3 years ago

Could this be done for python3.8 . The datastore is running 3.8 and is the primary user of the datagetter. May require update to CI. Thanks

odscjames commented 3 years ago

Datagetter - update all requirements

odscjames commented 3 years ago

I can set Python 3.8 as min requirements for this in setup.py, update GitHub actions and rebuild deps - if we are sure no-one is using it below that?

odscjames commented 3 years ago

Chatted to @michaelwood - we'll do deps in Python 3.8, test in 3.6 -> 3.10, and put a note in the readme to say to anyone doing future dep work should use 3.8 & also 3.8 is the supported version

odscjames commented 3 years ago

I would argue 2 commits - the changes to the README document changes to the requirements file, so they really have to go together. Reverting the readme so it says "3.6" without also reverting the reqs doesn't make sense to me.

I'll do one commit with the GitHub changes - which will also answer your question - and a 2nd with docs & req.

odscjames commented 3 years ago

Do the tests run correctly before the requirements file was updated?

Yes https://github.com/ThreeSixtyGiving/datagetter/actions/runs/1477517053