search

ThreeSixtyGiving / datagetter

Scripts to download data from http://registry.threesixtygiving.org
MIT License
1 stars 1 forks source link

github: tests: Add a quick cache check #50

Closed michaelwood closed 1 year ago

michaelwood commented 1 year ago

This just verifies there aren't any errors generated after running the datagetter when it uses its cache.

Also add some additional comments.

R2ZER0 commented 1 year ago

Not sure I'm quite grasping this - are we checking to see that the cache worked, by seeing if the json files were successfully copied from cache_dir to data?

michaelwood commented 1 year ago

Not sure I'm quite grasping this - are we checking to see that the cache worked, by seeing if the json files were successfully copied from cache_dir to data?

We're just checking that when the cache has been warmed up by the previous run of the datagetter the datagetter doesn't crash. After its run also we look at the files after running it the second time and use the presence of a non-zero exit status of any of the -run tasks to test it worked.

This is a basic stop gap solution until unit tests are developed for the datagetter.