search

ThreeSixtyGiving / dataquality

Other
1 stars 1 forks source link

Codelist links are broken #80

Closed KDuerden closed 1 year ago

KDuerden commented 1 year ago

When incorrect codes are included in closed codelist the DQT provides an error message with a hyperlink to the codelist, however these links all direct to the wrong place, for example

image

Also to note, there are 5 codelist fields with errors in the example file being tested but only 4 of them are listed as having problems - see feedback

There are also only 'Other errors' with specifics about the issue for currency and country code (which are the two enum'd codelists, so is this influencing this behavour?)

The dummy data being tested is attached. Dummy-data-for-testing-codeerrors.xlsx

Bjwebb commented 1 year ago

When incorrect codes are included in closed codelist the DQT provides an error message with a hyperlink to the codelist, however these links all direct to the wrong place, for example

Looks like the service we used to use for "pretty" view of a CSV has gone.

Would you like the link to go to https://standard.threesixtygiving.org/en/latest/technical/codelists/#regrant-type instead?

Also to note, there are 5 codelist fields with errors in the example file being tested but only 4 of them are listed as having problems - see feedback

Looks like "To Individuals Details:Grant Purpose" is missing, I'll do some digging into why.

There are also only 'Other errors' with specifics about the issue for currency and country code (which are the two enum'd codelists, so is this influencing this behavour?)

Yes, I think this is due to enums. I think we should be able to combine this with the codelist errors, I can do some initial investigation into that.

KDuerden commented 1 year ago

Thanks Ben

Would you like the link to go to https://standard.threesixtygiving.org/en/latest/technical/codelists/#regrant-type instead?

Yes, I think linking to the more user friendly codelist tables for those we manage via CSVs would be great. Not sure what to suggest for the enums, as we wanted to avoid having to put such long lists in the docs.

Looks like "To Individuals Details:Grant Purpose" is missing, I'll do some digging into why.

It did appear at points I played around by adding and removing errors, so I don't think it's a fixed issue effecting just one codelist, but something to do with a max number to show maybe?

Bjwebb commented 1 year ago

I think everything in this issue has been done, except for fixing the display of enums vs non-enums, which I've split out into it's own issue https://github.com/ThreeSixtyGiving/dataquality/issues/86