lib360dataquality: Use percent calculations based on the grant type

ThreeSixtyGiving / dataquality

Other

1 stars 1 forks source link

lib360dataquality: Use percent calculations based on the grant type #89

Closed michaelwood closed 1 year ago

michaelwood commented 1 year ago

If error counts are only relevant to recipient organisations then show the percentage total only for that group of grants. e.g. 100% of grants to recipient organisations.

Also pass in aggregates data to avoid needing to iterate and count the different types of grant recipients.

fixes: https://github.com/ThreeSixtyGiving/dataquality/issues/88

michaelwood commented 1 year ago

Thanks @Bjwebb , found another related thing I needed to fix too. Please could I get a re-review on this. Thanks