search

ThreeSixtyGiving / datatester

Scripts to asses the quality of data from http://data.threesixtygiving.org
MIT License
3 stars 2 forks source link

Add coverage.py to generate coverage.json with coverage info #22

Closed Bjwebb closed 5 years ago

Bjwebb commented 6 years ago

11

coverage.json outputted at: https://storage.googleapis.com/datagetter-360giving-output/branch/11-coverage/coverage.json

robredpath commented 5 years ago

@drkane - I hear you're doing some work on coverage! Does the file @Bjwebb linked to above help? Are there any changes you'd need for this to be useful?

drkane commented 5 years ago

@robredpath @Bjwebb Sorry for the super-long delay in responding to this! The coverage work I was doing was delayed, but I'm now back working with @KDuerden on it.

Having used the new file I think it definitely works for our purposes, so if it's possible to implement these changes that would be great.

robredpath commented 5 years ago

Great :) That work is in the sprint plan - should be done over the summer :)

On Tue, 18 Jun 2019 at 14:11, David Kane notifications@github.com wrote:

@robredpath https://github.com/robredpath @Bjwebb https://github.com/Bjwebb Sorry for the super-long delay in responding to this! The coverage work I was doing was delayed, but I'm now back working with @KDuerden https://github.com/KDuerden on it.

Having used the new file I think it definitely works for our purposes, so if it's possible to implement these changes that would be great.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/datagetter/pull/22?email_source=notifications&email_token=AAE4P4JESJG2QAZBVHX7IUDP3DNIVA5CNFSM4FOO7W2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6SFFQ#issuecomment-503128726, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4P4MY47B3INW6T52ZLBLP3DNIVANCNFSM4FOO7W2A .

--

Open Data Services Co-operative Limited is a company limited by shares, operated as a Workers' Co-operative Registered in England. Company number: 09506232 http://www.opendataservices.coop

KDuerden commented 5 years ago

thanks @robredpath so is updating the coverage file a deliverable in the sprint? eg something that will get done? If its only should get done can we discuss with you & @morchickit? @drkane and I will need this type of coverage information to be able to progress with the dashboard, so if there's a chance it isn't going to happen, we need to know sooner rather than later so we can work out next steps.

robredpath commented 5 years ago

@KDuerden yup, it's a 'will do' in the sprint

drkane commented 5 years ago

@robredpath That's great. Is there any way of quickly re-running with the latest data using the version in this branch? Doesn't have to be an ongoing process until it's merged, but would be great if this coverage.json had the latest data in it for developing.

robredpath commented 5 years ago

@drkane I'm pretty sure that's generated automatically by Travis when this PR gets updated. It looks like master has been updated so I've merged in the changes. Check in the morning and let me know how it looks!

robredpath commented 5 years ago

@drkane I've just checked in on this before clocking off and it looks like the file's updated. Enjoy!

michaelwood commented 5 years ago

Thanks. I have now merged this.