search

ThreeSixtyGiving / datatester

Scripts to asses the quality of data from http://data.threesixtygiving.org
MIT License
3 stars 2 forks source link

Data Registry / Daily data test not updated since 2019-05-15 #38

Open KDuerden opened 5 years ago

KDuerden commented 5 years ago

Travis is reporting failure: https://travis-ci.com/ThreeSixtyGiving/datagetter/builds/112330950

KDuerden commented 5 years ago

We have a new publisher so I wanted to check the status of this - any ideas on when the Registry will be updating again?

robredpath commented 5 years ago

This is due to the link to the SCVO Cyber Essentials grants JSON file now returning an HTML page and a 404 code, and datagetter not being able to handle that.

In the very short term, removing that file from the Registry will fix the DDT. I've tried a couple of things to handle the error more cleanly in datagetter but run out of time today. I can check in on this with @kindly tomorrow to work out where I've been going wrong!

KDuerden commented 5 years ago

Thanks - I'll take it down & contact SCVO - they changed some things in their publishing process so might be a knock on effect

KDuerden commented 5 years ago

@robredpath I've removed that file now, so is it possible to re-start the build? I'm happy to run it if that's appropriate!

robredpath commented 5 years ago

@KDuerden - I restarted the build; do feel free to do this yourself in future if you want, you won't break anything (that isn't already broken!)

I've also written up the issue in https://github.com/ThreeSixtyGiving/datagetter/issues/41 for a record of what needs doing to fix this properly.

KDuerden commented 5 years ago

@robredpath thanks "you won't break anything (that isn't already broken!)" is exactly the reassurance I need :)