search

ThreeSixtyGiving / grantnav

This is a web based search tool for data in the 360 giving data format.
http://grantnav.threesixtygiving.org/
Other
9 stars 5 forks source link

Cookie data syntax - white space in Cookie banner code #1097

Open mariongalley opened 2 weeks ago

mariongalley commented 2 weeks ago

When setting the cookie, the semi colon has a space before it, instead of after it so this document.cookie = "noEnhancedAnalytics=1 ;max-age=2592000 ;domain=" + domain; Should be this: document.cookie = "noEnhancedAnalytics=1; max-age=2592000; domain=" + domain;

Please update across all 360Giving tools that use the Universal Cookie banner

michaelwood commented 2 weeks ago

Some browsers seem to be parsing the cookie data with a semi-colon and a space rather than just a semi-colon, so we need to change this to either omit the white space or add it after the semi-colon as suggested.

This works: "noEnhancedAnalytics=1;max-age=2592000;domain=threesixtygiving.org" or as suggested "noEnhancedAnalytics=1; max-age=2592000; domain=threesixtygiving.org"

https://www.rfc-editor.org/rfc/rfc6265#section-4.2.1