ThreeSixtyGiving / grantnav

This is a web based search tool for data in the 360 giving data format.
http://grantnav.threesixtygiving.org/
Other
9 stars 5 forks source link

Link to Insights from GrantNav search results #573

Closed robredpath closed 3 years ago

robredpath commented 3 years ago

You'll be able to click a link in GrantNav search results to see those results in Insights

We'll make it so that Insights can accept a URL instead of having to upload a file, and get that change merged.

If it's easy, we'll also add flags to not do some of the enhancements, as that would make it quicker.

We'll add a link to GN search results; if there's a maximum size limit by experimentation and see if we need to only show it for smaller results set.

michaelwood commented 3 years ago

@drkane My thinking is:

Add new button in the export results area something along these lines:

insights

The button would send you to a web page on insights that effectively re-use all the existing loading stuff that is currently used on the main upload/fetch. So something like https://insights.threesixtygiving.org/fetch/grantnav?url=https://grantnav.threesixtygiving.org/...download..json (In Insights we check url in an allow-list of *.threesixtygiving.org )

Another approach I thought of is doing it all on the grantnav side and use the existing end points on Insights. So JS on grantanv POSTs to insights....org/fetch/url . Then polls the insights....org/job/ and then redirects to the results page. However as nice as it would be to re-use existing Insights JSON endpoints it would be a bit of a strange flow for the user. (We would also need to add grantnav to the Access-Control-Allow-Origin).

drkane commented 3 years ago

I think redirecting via a button is definitely the best way to do it.

I think the key thing for users will be making sure that the stuff that 360Insights adds (eg location data, organisation data) is included in the GrantNav JSON after being brought through from the datastore. That way Insights can skip the steps that take the longest time, which are fetching the data about org ids.

I can make the changes to Insights that means its skips those fields if they're already in the data.

morchickit commented 3 years ago

A button is a great idea. Can I pitch in and say that the text need to be more descriptive? We need something like - "open in insights" or else people will be confused. Most of them are not aware of insights according to the user research.

On Mon, 2 Nov 2020 at 15:43, David Kane notifications@github.com wrote:

I think redirecting via a button is definitely the best way to do it.

I think the key thing for users will be making sure that the stuff that 360Insights adds (eg location data, organisation data) is included in the GrantNav JSON after being brought through from the datastore. That way Insights can skip the steps that take the longest time, which are fetching the data about org ids.

I can make the changes to Insights that means its skips those fields if they're already in the data.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ThreeSixtyGiving/grantnav/issues/573#issuecomment-720550917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY7HO6BLH74B7GWGN4J5W3SN3HQ7ANCNFSM4TDT472A .

-- Mor Rubinstein Programme Manager 360Giving http://www.threesixtygiving.org/ Twitter - @morchickit https://twitter.com/Morchickit Cell: +44(0)7904191881 / Office: 02078123773 Skype: mor.rubinstein See grantmaking in different ways, with our new visualisation platform 360Insights https://insights.threesixtygiving.org/ 360Giving is a company https://beta.companieshouse.gov.uk/company/09668396 limited by guarantee and a registered charity http://beta.charitycommission.gov.uk/charity-details/?regid=1164883&subid=0 . Read our privacy notice http://www.threesixtygiving.org/privacy/ to find out how we collect and use personal data.

drkane commented 3 years ago

Agree @morchickit - this is probably for the next sprint, but we need to think about what it looks like and what the copy for the link is. One thing that @robredpath suggested is that we replace the top summary card with something more visual (eg a couple of small example charts) that then says "Get more insights from 360Insights >>>" or similar.

robredpath commented 3 years ago

We can definitely look at this next sprint - there's plenty of ways that we can indicate to people what the button does.

That said, I do also think that you don't actually need to know what 360Insights is in order for a button to make sense - someone clicking a button with a bar chart icon and the word "insights" would expect to see some graphs, some filters and some things they can click to explore the data....which is exactly what they get.

What isn't clear is that it'll take them to a different website, and they'll likely see a loading page. A text link would definitely help there, or we might be able to add some additional icon to indicate that it's an external (to GN) link.

drkane commented 3 years ago

Insights <> GrantNav integration

mariongalley commented 3 years ago

Link to Insights should be conditional based on number of results - see comment in #597