Links in "where is this data from" on grant page aren't styled as links

[stevieflow]

Yes - this should be fixed - it's not very intuitive or accessible to present things in the current way

I would suggest this has to be higher than low priority, also

[BibianaC]

The text-decoration: none; that is in theme.css should be disabled as it is above on the Funding/Recipient organization links. I don't see the difference that makes one work and the other one not.

If we want all the links to be underlined then we can just delete it from theme.css but it might be that in other parts of the website we do want the text decoration to be none.

Any thoughts @michaelwood @Lathrisk ?

[Lathrisk]

theme.css is ~now~ generated from the scss files, so deleting it there means it will get overwritten the next time we generate that file.

This particular rule is in _reset.scss, the purpose of which is usually to standardise styling across browsers and remove unwanted defaults. A better approach might be to create a new rule that targets the links and applies the relevant styling - custom.scss is probably the best place for that.

[drkane]

I think this might need some changes to the design system CSS - it looks like the var(--colors-alt) value is wrong, it should be one of the main color vars.

On the underline - originally the style guide didn't have any underlines for links, which I don't think it very accessible. So we've been adding them back in, but the default is still for links to not be underlined. I think eventually we should swap this around so the default is for underline and we switch it off where not needed.

I'll make the change in the design system so that links in boxes use the right colour and are bold and underlined.

[drkane]

I've made some changes to the design system that should make the links more prominent in boxes.

[michaelwood]

I've deployed some other fixes and @BibianaC was included in the latest update. Now closing.