ThreeSixtyGiving / grantnav

This is a web based search tool for data in the 360 giving data format.
http://grantnav.threesixtygiving.org/
Other
9 stars 5 forks source link

Export data buttons for funder and recipient pages #654

Open drkane opened 3 years ago

drkane commented 3 years ago

The links to downloads from the Funder & Recipient pages don't work:

michaelwood commented 3 years ago

Note for future - the Download component for CSV and JSON

{% include 'components/export-data-button--json.html' with data_function='search.json' query_string=query_string %}

Doesn't seem to allow a direct url as an argument. Attempts at:

 {% url 'example.csv' example.id  as link %} 
{% include 'components/export-data-button--json.html' with data_function=link query_string=query_string %}

didn't work. I think this component needs further generic-ifying and leave more of the logic for the download target to the template that it is in. The target doesn't follow a very consistent pattern, e.g. some are search queries and some are specific end points in the backend.

stevieflow commented 3 years ago

Working down post new design GrantNav issues

odscjames commented 3 years ago

Funder pages seem to work now? Recipient pages too? (Just tested both)

Is this being left open for @michaelwood comment about the component and URL's, or should that be moved somewhere else and this closed?