search

ThreeSixtyGiving / grantvis

GrantVis - Visual 360Giving Data explorer
https://grantvis.threesixtygiving.org
GNU General Public License v3.0
0 stars 0 forks source link

Income of Recipients bands should match live #221

Closed mariongalley closed 10 months ago

mariongalley commented 11 months ago

Live

image

Dev

image

michaelwood commented 11 months ago

These were changed to match GrantNav/Insights's 'Award amount' bands after it was mentioned they were inconsistent.

mariongalley commented 11 months ago

@michaelwood That's fair enough for the Amount Awarded chart but the income of recipients chart doesn't have an analogue in GrantNav, and I think the previous banding made more sense (organisation income can be expected to be higher than grant sizes so doesn't need as many very small bands)

michaelwood commented 11 months ago

The insights does have the same top-band (Over £10m) as the GrantNav standard.

For prioritisation - To have custom bands would be ~0.5 day effort because it means not being able to use the existing tested GrantNav code for the banding aggregations, preference from a technical complexity point of view would also be to live with this if possible.

michaelwood commented 10 months ago

New bands have been implemented. Fixes deployed.

Note slight difference as the labels use the GrantNav text format so will continue without the suffixes (apart from the manual ones "Up to" and "Over").