github-actions[bot]
commented
9 months ago Pull Request Test Coverage Report for Build 7667703669
- 3 of 10 (30.0%) changed or added relevant lines in 2 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-5.8%) to 65.217%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| insights/init.py | 1 | 4 | 25.0% | ||
| insights/redirect_helpers.py | 2 | 6 | 33.33% | ||
| <!-- | Total: | 3 | 10 | 30.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| insights/init.py | 1 | 73.68% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 7661332689: | -5.8% |
| Covered Lines: | 30 |
| Relevant Lines: | 46 |
michaelwood
This adds support for
/?funder=orgid&funder=orgidand refactors support for/data?funder=orgid&funder=orgidto make it re-usable in two places.One improvement for future would be to add something on insights itself to let people know they're using an old style link. The 360-ds has an alert tag that could be used https://cdn.threesixtygiving.org/components/detail/alert-tag--default (not particularly pretty but that might be part of the point!).
@mariongalley @KDuerden