ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published
Other
0 stars 0 forks source link

Include Publisher Logos on Publisher Dashboard #118

Closed mariongalley closed 1 year ago

mariongalley commented 2 years ago

This is required to satisfy #115

KDuerden commented 2 years ago

My preferred placing would be right aligned at the same level as the publisher name, on the publisher detail page.

image

This would mean the publisher list would not have the logo showing, but as the design doesn't really allow for adding an image, I think that is ok.

KDuerden commented 1 year ago

Not all funders have a logo, or we don't get permission to use it.

The update to add the logo to the Dashboard currently has a link to the funder website as part of the logo, but when that is missing, it has a missing image icon instead.

For example

image

Is there a way to make this fail more elegantly when there isn't a logo?

mariongalley commented 1 year ago

@codemacabre See Katherine's update above

mariongalley commented 1 year ago

@codemacabre This is fixed in dev, thank you