Prerequisites for registry deprecation - Githubissues

ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published

Other

0 stars 0 forks source link

Prerequisites for registry deprecation #134

Closed codemacabre closed 1 year ago

codemacabre commented 1 year ago

Summary

Upgrade engine to Node 18.16.0 (LTS)
Upgrade dependencies to be compatible with Node 18.16.0
Set ESlint rules to warn to avoid breaking build
Fix asset path in CSS (temporary)
Add image assets
Display licence icons for all licence types

Fixes https://github.com/ThreeSixtyGiving/registry/issues/84

Update 'See More' to more descriptive link

Fixes https://github.com/ThreeSixtyGiving/registry/issues/107

Add badge filter

Fixes https://github.com/ThreeSixtyGiving/registry/issues/75

Add publisher logos to publisher detail page

Fixes https://github.com/ThreeSixtyGiving/registry/issues/118

Sort files by max_award_date

Fixes https://github.com/ThreeSixtyGiving/registry/issues/120

Add accessURL link
Add grant range text

Fixes https://github.com/ThreeSixtyGiving/registry/issues/121

Add Insights link to publisher page
Update GrantNav link to funders search

Fixes https://github.com/ThreeSixtyGiving/registry/issues/111

Change recipient org counter wording in top stats

Fixes https://github.com/ThreeSixtyGiving/registry/issues/138

Update header
Update footer

Fixes https://github.com/ThreeSixtyGiving/registry/issues/122

michaelwood commented 1 year ago

Test looks like it's failing because we're getting blocked by twitter via a 403 http status code. I think it's fine to put something like:

for link in links:
+   # twitter blocking requests
+    if "twitter" in link.get_attribute("href"):
+        continue

in https://github.com/ThreeSixtyGiving/registry/blob/dashboard/tests/test_functional.py#L139 to skip over that one.

michaelwood commented 1 year ago

Thanks for all this work. Work combined into #141 . Future improvements and developments can now be done in a branch off of "dashbaord" branch.