search

ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published
Other
0 stars 0 forks source link

Redesign #56

Closed drkane closed 4 years ago

drkane commented 4 years ago

Changes to the registry to incorporate design changes to 360Giving's new style.

There are still some outstanding to-do items, but I wanted to set the ball rolling. Ideally this would be merged on Monday 16th March.

Outstanding issues (@drkane to action):

stevieflow commented 4 years ago

@drkane just checking :

Menu items need to be finalised

is not ticked off - is that OK?

drkane commented 4 years ago

@drkane just checking :

Menu items need to be finalised

is not ticked off - is that OK?

Might be worth waiting to approve the pull request until they're done, they won't be finalised until we launch the main site today. But updating them is very simple (there's a JSON file which contains the contents of these links) and so I can do it quickly after we've launched the main site.

stevieflow commented 4 years ago

OK thanks @drkane - so we should just review/approve https://github.com/ThreeSixtyGiving/standard/pull/273 - and then wait for your sign to fully check this one?

drkane commented 4 years ago

@stevieflow - We need to wait for the menus for the standard too.

What I wasn't sure for this one was how the actual updating of the server works after the PR is approved. For the standard I think it's all handled by readthedocs.