Filters

[Lathrisk]

Publisher filters are under full review and possible redesign.

[mariongalley]

Propose to introduce filtering of publishers list by quality facet i.e. does/does not share Programme name, has/has not published in the last 3 months etc.

[codemacabre]

@mariongalley Michael raised the very good point that in its current (unreleased) implementation, the new badge filter will display publishers with any one of the selected badges (i.e. an OR), but you may want it to only select publishers with all of the selected badges (i.e. an AND).

OR:

AND:

If that makes sense, please could you let me know which implementation of the filter you'd prefer?

[mariongalley]

@codemacabre I think the AND logic would be preferable for this use-case.

Also can I check whether there's currently a way to filter either positively or negatively i.e. 'does share Programme name' but also 'does not share Programme name'?

[codemacabre]

@codemacabre I think the AND logic would be preferable for this use-case.

Thank you @mariongalley I'll get on that.

Also can I check whether there's currently a way to filter either positively or negatively i.e. 'does share Programme name' but also 'does not share Programme name'?

Not currently, but implementing it might involve some design decisions a little beyond the scope of this initial work. What do you envision the UI looking like?

[mariongalley]

@codemacabre Agreed, it will require some design thought! I think it would be good to take inspiration from GrantNav, which has include/exclude selected options at the top of some filters.

This wouldn't allow for a granular choice on a per-feature basis, but seems like an acceptable solution if we're OK with having to include all the selected features or exclude all the selected features.

[codemacabre]

@mariongalley Does this sound like a decent plan?

1. Set filters to work with AND rather than OR
2. Add the filters sidebar to the dashboard (similar to GrantNav)
3. Move the Select Publishers and Select Badges filters to the sidebar (keeping the sort at the top of the search results)
4. Allow including and excluding filter functionality (as in GrantNav)

Very crude mockup:

[mariongalley]

@codemacabre Is the reason for moving the filters to the left that there would now be essentially one picker for each quality feature rather than a shared picker for all of them?

Yes, what you've described is exactly right thank you

[codemacabre]

@mariongalley I was thinking it would just make the design and flow more consistent across applications rather than split each feature into its own filter, as that might be a bit busy compared to the shared picker. Happy to give it a try if you want to see how that works, though.

[mariongalley]

@codemacabre That makes sense - no go ahead and do what you had in mind!

[codemacabre]

@mariongalley Just working on this and noticed some odd behaviour with the publisher filter and new badge filter (the AND version not yet live). It seems the publisher filter uses OR, so when combined with badge filters, the results are quite unexpected.

There are definitely a couple of bugs to iron out, but I wondered if there is a use case for combining the publisher filters with badge filters, and if so, how it should work? Or should changing the badges filter automatically clear the publisher filter?

[mariongalley]

@codemacabre Ideally we would like to be able to filter by data quality feature for a group of selected publishers. Do you mean that it is showing unexpected results because there are sometimes no relevant publishers to return, or is it that you're unable to set up a query that correctly returns any of the selected publishers that have all (or none, if exclude) of the selected features?

[codemacabre]

@mariongalley Deployed on the dev site.

[mariongalley]

Thanks for this @codemacabre - would it be possible to limit the maximum width of the contents of the tabs, like in the live dashboard?

At the moment on the All Data tab, the tab switching feels really lonely all the way off to the left of the screen, and on the Publishers tab the Heatmap looks really wide and is harder to read as a result.

All Data - live

All Data - dev

Publishers tab - live

Publishers tab - dev

With the addition of the filters I think it makes sense for them to sit in the left margin outside of the main content 'pane' (not sure the right word for this)

[mariongalley]

In terms of the functioning of the filter, so far they all behave as expected except the two duration features, which return no results despite many publishers having those badges

[mariongalley]

@codemacabre I've retested and these all work as expected now. The only blocker to launch is the additional information area which doesn't quite look right to me.

[codemacabre]

The only blocker to launch is the additional information area which doesn't quite look right to me.

@mariongalley Is the issue the overall placement? The layout is an exact duplicate of the one currently on the registry, but the width looks a bit odd to me. Perhaps it needs to be wider? Or a smaller font size?

[mariongalley]

@codemacabre It's not so much the layout as the fact the font weight etc didn't match the rest of the Quality Dashboard. However, I commented on #122 that I think we can reproduce the functionality while getting rid of the explainer copy.

[codemacabre]

Deployed to live!