ThreeSixtyGiving / registry-classic

Registry for 360Giving files that were published
Other
0 stars 0 forks source link

Grants published/awarded heat map doesn't display 2022 grants #91

Closed KDuerden closed 2 years ago

KDuerden commented 2 years ago

There are already a few funders with grants awarded in 2022 but these aren't showing the heat maps.

For example

http://dashboard.360dashboard.vs.mythic-beasts.com/publisher/360G-esmeefairbairn

image

They have already made 22 grants

It looks like the chart might be hard coded with the 2011 to 2021 segments.

Also can this chart be renamed from

Total grants awarded to Total grants published

michaelwood commented 2 years ago

Leaving this open as we need to fix this programatically rather than defined in https://github.com/ThreeSixtyGiving/registry/blob/dashboard/registry-vue/src/components/generic/awardYears.js file

KDuerden commented 2 years ago

It would be good to get a programmatic fix for the heat maps sorted out, as part of iterative improvements.

Lathrisk commented 2 years ago

@KDuerden @mariongalley I've updated the code such that the most recent year is the current year, and data is generated for 12 years previous, as well as an entry for all data before the 12th year prior.

So in this instance the most recent year is 2022, the earliest year is 2011, and an additional entry exists for "Older data".

The number of previous years can be easily changed. I think 12 fits in terms of page spacing, but it might not be significantly beneficial over 10, or 8 (below is a screenshot of 12 years of data).

years-data

mariongalley commented 2 years ago

Fantastic, thanks @Lathrisk

KDuerden commented 2 years ago

Thanks that is really great. The publisher detail page explains that it shows past 10 years + aggregated years, so it would be good to stick with 10 + 1 (but if people disagree, we'll need to update that text)

image

mariongalley commented 2 years ago

Good point - I think 10 years seems more 'logical', but I think 11 years looks good in terms of spacing. Not sure either is a great reason to prefer one over the other 😆 I'd be inclined to opt for 10 years + older?

Lathrisk commented 2 years ago

This has now been deployed.